.github/workflows/manylinux.yml (2)

155-170: Consider clarifying step names for readability.

The step at line 155 is named "Save OpenCV cache (full)" but performs validation, while line 165 "Save OpenCV cache (full) - upload" does the actual cache save. This split is functionally correct (validation failure prevents upload), but the naming could be clearer.

📝 Suggested rename for clarity

-      - name: Save OpenCV cache (full)
+      - name: Validate OpenCV install (full)
         if: steps.opencv-cache.outputs.cache-hit != 'true' && github.event_name == 'push' && github.ref == 'refs/heads/main'
         run: |
           config=$(find ${GITHUB_WORKSPACE}/opencv_artifacts -name 'OpenCVConfig.cmake' | head -1)
           ...
         shell: bash
-      - name: Save OpenCV cache (full) - upload
+      - name: Save OpenCV cache (full)
         if: steps.opencv-cache.outputs.cache-hit != 'true' && github.event_name == 'push' && github.ref == 'refs/heads/main'

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/manylinux.yml around lines 155 - 170, Rename the two steps
so their names reflect their intent: change the first step currently named "Save
OpenCV cache (full)" (the validation block that checks for OpenCVConfig.cmake)
to something like "Validate OpenCV artifacts (before cache save)" and keep or
change the second step "Save OpenCV cache (full) - upload" to "Save OpenCV cache
(full)" or "Upload OpenCV cache (full)"; update only the name fields in the YAML
so the validation step clearly indicates it’s a check and the later step clearly
indicates it performs the cache upload.

---

245-260: Same naming suggestion applies to slim build validation/upload split.

For consistency with any changes made to the full build steps.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/manylinux.yml around lines 245 - 260, Rename the slim
cache steps and keys to mirror the naming convention used for the full build
steps so they stay consistent; update the step names "Save OpenCV cache (slim)"
and "Save OpenCV cache (slim) - upload" and the cache key string "opencv-${{
env.OPENCV_VERSION }}-manylinux2_28-slim-${{
hashFiles('cmake/opencv_build_options_slim.cmake') }}" to match the same pattern
used by the full build (e.g., replace or align the "-slim" suffix/label and any
prefix differences), and ensure the if conditions and path (${{ github.workspace
}}/opencv_artifacts_slim) remain correct after renaming.